Skip to content

Expose all components in SimpleKGPipeline init and config #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Expose all components in SimpleKGPipeline init and config #314

wants to merge 5 commits into from

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented Mar 20, 2025 •
edited
Loading

Description

This PR exposes all components in the SimpleKGPipeline constructor, ie make it possible to customize all the components in the pipeline, including the entity extractor and resolver.

I also took the opportunity to revisit some type definition to remove type: ignore comments by leveraging generics.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Medium

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia marked this pull request as ready for review March 20, 2025 16:16
@stellasia stellasia requested a review from a team as a code owner March 20, 2025 16:16
@stellasia stellasia changed the title Feature/skgp expose all components Expose all components in SimpleKGPipeline init and config Mar 20, 2025
@stellasia stellasia marked this pull request as draft March 20, 2025 16:27
@stellasia stellasia marked this pull request as ready for review March 20, 2025 17:13
NathalieCharbel
NathalieCharbel approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@NathalieCharbel NathalieCharbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stellasia stellasia marked this pull request as draft March 28, 2025 12:22
@stellasia
Copy link
Contributor Author

Discussed offline, converting to draft again because exposing all components would lead to weird scenearios since driver and llm (for instance) are still mandatory parameters. Requires rethinking. Might close this PR as well if no time to rework it.

@stellasia stellasia closed this Apr 15, 2025
@stellasia stellasia deleted the feature/skgp-expose-all-components branch April 15, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathalieCharbel NathalieCharbel NathalieCharbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellasia @NathalieCharbel